Fix: Enhance zipped submissions support - follow up #174
Merged
alexskr merged 7 commits intoncbo:developfrom Sep 11, 2023
Merged
Fix: Enhance zipped submissions support - follow up #174alexskr merged 7 commits intoncbo:developfrom
alexskr merged 7 commits intoncbo:developfrom
Conversation
application/x-gzip is a deprecated mimetype add unit test for determining gzip mimetype
This reverts commit 72c950a.
…ed file submitted
Codecov Report
@@ Coverage Diff @@
## develop #174 +/- ##
===========================================
+ Coverage 80.75% 80.80% +0.04%
===========================================
Files 63 63
Lines 4901 4907 +6
===========================================
+ Hits 3958 3965 +7
+ Misses 943 942 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a fork of @alexskr solution (#172), handling the remaining the not passing test of #144
This iteration uses
zlibmodule, to unzipGzfiles (it seemszipmodule does not handle it).Thanks, @alexskr for contributing to this.